Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Custom Vision object detection sample #952

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jwood803
Copy link
Contributor

@jwood803 jwood803 commented Apr 17, 2022

Adding weather recognition sample to go along with the Custom Vision ONNX tutorial

@jwood803 jwood803 marked this pull request as ready for review April 29, 2022 23:54
@jwood803
Copy link
Contributor Author

@luisquintanilla, I think this is ready for review. I could have missed some stuff, so just let me know if anything needs to be updated.

@jwood803 jwood803 changed the title Adding weather recognition sample Adding Custom Vision object detection sample May 17, 2022
@jwood803
Copy link
Contributor Author

@luisquintanilla This should now be ready for a review

Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwood803 Looks good. Added a few comments to the README

@luisquintanilla
Copy link
Contributor

luisquintanilla commented May 27, 2022

Additional comments:

  • When using Visual Studio the output is written to the build output directory, not at the project directory level. Update paths so that we ensure regardless of whether using the CLI experience of VS, the output is written at the project directory level.
  • Let's try and bump up the font size of the text and either change the color of the bounding box or bump up the thickness. Red bounding box / text on red stop sign makes it difficult to read.

@jwood803
Copy link
Contributor Author

jwood803 commented Jun 1, 2022

@luisquintanilla Updated, but let me know if any more changes are needed.

@luisquintanilla
Copy link
Contributor

Thanks @jwood803. For some reason it's still not saving to the top-level directory.

@luisquintanilla
Copy link
Contributor

@jwood803 check out my branch for changes that work in VS. Make sure that dotnet run gives you the same result.

https://github.com/luisquintanilla/machinelearning-samples/tree/cv-onnx/samples/csharp/end-to-end-apps/StopSignDetection_ONNX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants