Cert rotator #4617
Merged
Cert rotator #4617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caaavik-msft
previously approved these changes
Jan 8, 2025
e-kharion
previously approved these changes
Jan 8, 2025
LoopedBard3
previously approved these changes
Jan 8, 2025
DrewScoggins
dismissed stale reviews from LoopedBard3, e-kharion, and caaavik-msft
via
75e815d
|
I was thinking, maybe we should move the behavior of CertRotator into CertHelper. That way we always bring along what we need on every run, and we don't have to worry about pushing updates to CertRotator out to machines. |
|
Would the idea be to then run the CertRotator functionality every run as well? I think that makes sense, especially from the standpoint of having a clear update flow. |
|
Yeah, that would be the idea. We would check on the certs before we started the upload. |
LoopedBard3
reviewed
Jan 8, 2025
e-kharion
previously approved these changes
Jan 14, 2025
LoopedBard3
reviewed
Jan 16, 2025
LoopedBard3
reviewed
Jan 16, 2025
LoopedBard3
reviewed
Jan 16, 2025
DrewScoggins
commented
Jan 16, 2025
|
Test runs for Arm64 are here, https://dev.azure.com/dnceng/internal/_build/results?buildId=2622437&view=results. Alpine and iOS are here, https://dev.azure.com/dnceng/internal/_build/results?buildId=2622440&view=results. |
sblom
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds certificate handling to auth code for upload