Handle skipped trivia in the C# tokenizer #11207
Open
+989
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reaction to dotnet/roslyn#75724. Will need to update to a version of Roslyn with this change to be able to test.
jjonescz
approved these changes
Nov 14, 2024
chsienki
approved these changes
Nov 14, 2024
jjonescz
reviewed
Nov 15, 2024
| // x #endif; | ||
| Diagnostic(ErrorCode.ERR_EndOfPPLineExpected, ";").WithLocation(5, 9)); | ||
| Diagnostic(ErrorCode.ERR_BadDirectivePlacement, "#").WithLocation(5, 3)); |
There was a problem hiding this comment.
So we already have this error. Why do we need the Razor one?
If there are cases where the C# error is not reported, we probably should add C# codegen tests for them.
There was a problem hiding this comment.
If there are cases where the C# error is not reported, we probably should add C# codegen tests for them.
Added StartOfLine_12.
jjonescz
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reaction to dotnet/roslyn#75724. Will need to update to a version of Roslyn with this change to be able to test.