Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send over the new sourcetext's content checksum when sending notification of textchanges #75928

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ToddGrun
Copy link
Contributor

Calculation of this on the server was taking quite a bit of CPU (about 11.6% in the scrolling speedometer during the typing scenario). Instead, pass this data over as part of the text change notification, similar to what SerializableSourceText's serialization code does.

image

…tion of textchanges

Calculation of this on the server was taking quite a bit of CPU (about 11.6% in the scrolling speedometer during the typing scenario). Instead, pass this data over as part of the text change notification, similar to what SerializableSourceText's serialization does.
@ToddGrun ToddGrun requested a review from a team as a code owner November 15, 2024 00:54
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 15, 2024
@ToddGrun
Copy link
Contributor Author

ToddGrun commented Nov 15, 2024

Test insertion build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10562135

Results didn't show any samples in GetContentHash OOP (and it doesn't appear to have increased time spent in that method in VS either)

baseline:
image

target:
image

@ToddGrun
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants