Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase cache assets file format version to 11 in 7.0.1xx #28222

Merged

Conversation

ocallesp
Copy link
Contributor

@ocallesp ocallesp commented Sep 27, 2022

Description

The cache assets file was modified in #27580 to store two new values DebugSymbolsFiles and ReferenceDocumentationFiles and hence the format version should be increased.

Original Issue: #1458

Customer Impact

The cache assets file format changed and this can cause builds to fail with weird errors difficult to debug.

Regression?

  • Yes
  • No

Builds can fail

Risk

  • [] High
  • Medium
  • [] Low

Medium risk. Even though this can affect all builds, doing a restore fixes this.

Verification

  • Manual (required)
  • Automated

Cache assets file now contains DebugSymbolsFiles and ReferenceDocumentationFiles
@ocallesp ocallesp requested a review from dsplaisted September 27, 2022 23:42
@ocallesp ocallesp enabled auto-merge September 27, 2022 23:43
@ocallesp ocallesp changed the title Increase cache assets file format version 7.0.1xx Increase cache assets file format version to 11 in 7.0.1xx Sep 27, 2022
@dsplaisted
Copy link
Member

@ocallesp Don't actually merge this yet, we will need to get approval for it.

@ocallesp ocallesp disabled auto-merge September 28, 2022 01:48
@ocallesp
Copy link
Contributor Author

ocallesp commented Sep 28, 2022

@ocallesp Don't actually merge this yet, we will need to get approval for it.

@dsplaisted Who should approve this change ?

@ocallesp ocallesp merged commit 2d5116c into release/7.0.1xx Sep 29, 2022
@ocallesp ocallesp deleted the increase-assetsfile-formatversion-17-0-1xx branch September 29, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants