-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Draft ] Adding tests for Fluent theme #10385
base: main
Are you sure you want to change the base?
Conversation
A bit of off-topic: The lucky test failure in debug is pretty much what #9906 was about by the looks of it, and I stand by what I said, that this should be queued on the app thread. |
|
||
#region Private Properties | ||
|
||
private Button TestButton { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fields really should come first, followed by auto-properties and properties. When editing code whatever is below your current edit is likely to not compile, which makes editing much more difficult when these are at the bottom of the file.
return; | ||
} | ||
|
||
#region Protected Methods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regions are not really used in modern code. Makes navigation more of a pain.
Personally, I think the control-level tests should be done visually. We should capture and compare bitmap images in various states. The WinUI design team would sign-off on the correct images. |
Issue Link : #8552
Description
Hello community members, we are working on writing tests for Fluent UI and ThemeMode property, and here is a basic structure of how I am planning to do this and would like to have your suggestions on how we can make this better. It is okay, if there is a completely different approach that should be taken up.
The tests that are present in this PR, can be divided into three parts :
From the approach that we have followed here, it may be better to put these tests under Integration Tests, but before that, I want your opinions on what limitations we can face with the above approach, or if there is some other approach that we can take to write these tests in a better fashion.
/cc @h3xds1nz @hughbe @JeremyKuhne @ThomasGoulet73 @miloush @lindexi @batzen
Microsoft Reviewers: Open in CodeFlow