Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid UCEERR_RENDERTHREADFAILURE #10394

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

petsuter
Copy link

@petsuter petsuter commented Feb 4, 2025

Fixes #9042

Main PR

Description

WPF applications with D3DImage can crash when a monitor is off or unavailable and IDirect3D9.GetAdapterMonitor returns NULL.
For example on laptops with connected HDMI external display and display setting “Extend”
and control panel “when I close the lid” = “Do nothing”, when closing the lid or on sleep / awake.

Customer Impact

WPF applications crash.

Regression

This bug exists in existing .NET releases like 4.8.

Testing

Take a laptop with connected HDMI external display and set display setting “Extend”
and control panel “when I close the lid” = “Do nothing”, then close the lid and check if a WPF application with D3DImage crashes.

Risk

Unclear.

Microsoft Reviewers: Open in CodeFlow

@petsuter petsuter requested review from a team as code owners February 4, 2025 09:28
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Feb 4, 2025
@miloush
Copy link
Contributor

miloush commented Feb 4, 2025

The fix looks reasonable to me and should probably be backported to .NET Framework, did you try out your solution? The "Testing" part is referring to how the PR changes were tested.

@petsuter
Copy link
Author

petsuter commented Feb 4, 2025

No, I have no time to test it sorry. I just run into the crash all the time.
Maybe @Const-me tested it. See #9042 (comment)

@miloush
Copy link
Contributor

miloush commented Feb 4, 2025

or @vladimir-cheverdyuk-altium, especially since this one requires particular hardware setup

@petsuter
Copy link
Author

petsuter commented Feb 4, 2025

particular hardware setup

A notebook and a monitor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One way to fix UCEERR_RENDERTHREADFAILURE
2 participants