-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows 11 Theming Changes #8870
Merged
Merged
Changes from 250 commits
Commits
Show all changes
272 commits
Select commit
Hold shift + click to select a range
43ef422
Add pr triggers for staging and release branches
singhashish-wpf 7c1ba0a
Adding win11 styles to progressbar, label and statusbar
harshit7962 97503f8
Applying Win11 Styles to TabControl, Frame, Page
harshit7962 ade8d80
Applying win11 theme to textblock
harshit7962 16e227a
Working code - Window and Theming API changes.
pchaurasia14 5c56fa1
Cleanup - Removing WindowCornerPreference and minor refactoring
pchaurasia14 928ef7e
Moving types from public to internal + bug fix for Window caption
pchaurasia14 dd3150d
Moving types from public to internal
pchaurasia14 50327da
Some cleanup
pchaurasia14 1b9551e
Some cleanup
pchaurasia14 fcd59a6
More cleanup
pchaurasia14 92e875d
Enable nullability for event and fix issue in ApplicationAccentColorM…
pchaurasia14 3752963
Merge pull request #8575 from pchaurasia14/WindowAndThemingAPI
singhashish-wpf c88e357
Adding win11 styles to ScrollBar and ScrollViewer
anjali-wpf 229513a
Merge branch 'main' of https://github.com/dotnet/wpf into feature/win…
anjali-wpf 09d7bf0
Merge branch 'feature/win11theming/staging' of https://github.com/dot…
anjali-wpf 7cc5d2f
Added Calendar Style
anjali-wpf 4ecfd27
Applying win11 styles to ListBox, ListBoxItem, Slider, togglebutton, …
harshit7962 20511e9
Fix Button Appearance and Calendar Button not showing
singhashish-wpf 73e9631
Added styling for ContextMenu
anjali-wpf c5bca65
Added win11 styles to ComboBox
anjali-wpf b953dcc
Merge pull request #8589 from dotnet/Calendarbuttonfixup
singhashish-wpf 354b4bf
Merge pull request #8587 from dotnet/CalendarChanges
singhashish-wpf 09a6773
Merge pull request #8578 from harshit7962/controlBatch1
singhashish-wpf 81c9494
Merge pull request #8590 from dotnet/ContextMenuChanges
singhashish-wpf 07d927a
Merge pull request #8586 from harshit7962/controlTextBlock
singhashish-wpf c2c580a
Merge pull request #8584 from dotnet/ScrollBarAndScrollViewerChanges
singhashish-wpf eaeeb68
Added win11 styles for ListView and ListViewItem (#8592)
anjali-wpf 9d1c01e
Merge branch 'main' of https://github.com/dotnet/wpf into feature/win…
anjali-wpf e63c1cd
Merge branch 'feature/win11theming/staging' of https://github.com/dot…
anjali-wpf c06683c
Adding win11 styles for DataGrid (#8594)
anjali-wpf 7e46930
Adding Win11 Styles to TreeView and TreeViewItem
harshit7962 4539028
Adding win11 styles to Expander and DatePicker (#8583)
anjali-wpf 8e4fd3d
Add ControlsDictionary and ThemesDictionary
singhashish-wpf 9c3505d
Add ControlsDictionary and ThemesDictionary
singhashish-wpf 239a5cf
Adding win11 styles to Menu and MenuItem (#8595)
anjali-wpf 20c812f
Fix namespaces and assembly names, added textbox xaml
singhashish-wpf 1e363e7
Merge branch 'feature/win11theming/staging' into ControlAndThemeDicts
singhashish-wpf beae99c
Merge pull request #8604 from dotnet/ControlAndThemeDicts
singhashish-wpf 989bbf8
Changed x:Class attribute value (#8607)
anjali-wpf 135e3b5
Adding win11 styles to RichTextBox and Separator (#8581)
anjali-wpf 13a597c
Fixed win11 theming changes for ListView and ListViewItem (#8629)
anjali-wpf 598a981
Fixing Api Compat Failure
harshit7962 faf4725
Merge branch 'feature/win11theming/staging' into controlBatch3
harshit7962 2a37acf
Added null check here on CanExecuteChanged to avoid exception (#8619)
anjali-wpf 1ef9bb7
Adding Win11 Styles to Combo box (#8593)
anjali-wpf d6ff403
Removing unused references
harshit7962 23be027
Resolving Merge Conflicts
harshit7962 ff1ae8c
Merge branch 'feature/win11theming/staging' into controlTreeView
harshit7962 cac0609
Merge pull request #8588 from harshit7962/controlBatch3
harshit7962 8c438a3
Merge pull request #8579 from harshit7962/controlBatch2
harshit7962 e560594
Merge pull request #8603 from harshit7962/controlTreeView
harshit7962 eb347a6
Import xaml styles in the integrated styles page
singhashish-wpf be77ee4
Moving ThemesDictionary and ControlsDictionary to parent namespace
pchaurasia14 28bb7fe
Merge pull request #8636 from dotnet/ExtraControlStyles
singhashish-wpf 430cf3f
Merge pull request #8637 from pchaurasia14/themingrefactoring
singhashish-wpf 748b70e
Update ApplicationThemeManager.cs to use correct namespace
singhashish-wpf 3e2fb9f
Merge pull request #8638 from dotnet/singhashish-wpf-patch-2
singhashish-wpf 09ffe67
Add missing FontIcon and ImageIcon classes
singhashish-wpf e9e7d31
Fix for fall back colours for high contrast theme
anjali-wpf 0b626fb
Making SymbolExtensions internal
singhashish-wpf 31e7187
Merge pull request #8648 from dotnet/fonticon
singhashish-wpf 2c6df32
Removing extra properties for ribbon
singhashish-wpf cffb2e5
fix(win11theme): ExpandDirection not respected in expander
harshit7962 47cc75c
Fix(win11theme): TabStripPlacement not Respected in tabcontrol
harshit7962 24c9cdd
Import FluentWindow and TitleBar
singhashish-wpf 0759d47
Adding win11 styles to PasswordBox (#8612)
anjali-wpf 41dbf0f
fix(win11theming): Ally and Navigation Issues in DataGrid
harshit7962 0679211
Merge branch 'win11dark' into feature/win11theming/appdemo
dipeshmsft 04ff61d
Fix(Win11Theming): Adding RepeatButton Styles
harshit7962 317de44
Add(Win11Theming): Bold, Italics, Underline, Floater and Paragraph St…
harshit7962 8a691d6
Add(Win11Theming): DocumentViewer, Hyperlink, List, ResizeGrip and Th…
harshit7962 8e89ddc
Add(Win11Theming): ContentControl, GridSplitter, GroupBox, GroupItem …
harshit7962 81dded1
Add(Win11Theming): Border, ButtonBase, Control, ItemsControl, TextBox…
harshit7962 e17d63d
Merge branch 'feature/win11theming/staging' of https://github.com/dot…
anjali-wpf 9b514fa
Add(Win11Theming): NavigationWindow Styles
harshit7962 8308477
Fixing margins in TreeViewItem
dipeshmsft 7dcd13c
Fix for Mica style dropping on theme change
dipeshmsft 8f62799
Fix(Win11Theming): TextBlock Foreground and FontIcon Issue
harshit7962 b4447ea
Fixed Border linear gradient for TextBox and PasswordBox
anjali-wpf 65dfd99
Fix(Win11Theming): MenuItems Dark Theme Visibility
harshit7962 86c1bd2
Fix(Win11Theming): TextBlock Foreground and FontIcon Issue
harshit7962 2db8ff5
Fix(Win11Theming): Menu Foreground Issue
harshit7962 9172107
Fix(win11theming): MenuBar hover highlighting
harshit7962 bb22bd5
Fix(win11theming): MenuItems hover highlighting
harshit7962 769e53d
Fix(Win11Theme): Add PasswordBox Styles to Resource Dictionary
harshit7962 bda8632
Merge branch 'pr-8652' into feature/win11theming/staging-mirror
dipeshmsft 60dd7c5
Merge branch 'pr-8654' into feature/win11theming/staging-mirror
dipeshmsft 684b3e2
Merge branch 'pr-8669' into feature/win11theming/staging-mirror
dipeshmsft 5612bb6
Merge branch 'pr-8691' into feature/win11theming/staging-mirror
dipeshmsft 7f68068
Merge branch 'pr-8697' into feature/win11theming/staging-mirror
dipeshmsft dc89647
Merge branch 'pr-8699' into feature/win11theming/staging-mirror
dipeshmsft 3696434
Merge branch 'pr-8741' into feature/win11theming/staging-mirror
dipeshmsft f9ab8e9
Merge branch 'pr-8743' into feature/win11theming/staging-mirror
dipeshmsft e3634c3
Merge branch 'pr-8744' into feature/win11theming/staging-mirror
dipeshmsft cd9a967
Merge branch 'pr-8745' into feature/win11theming/staging-mirror
dipeshmsft 83698b4
Merge branch 'pr-8748' into feature/win11theming/staging-mirror
dipeshmsft fe721c9
Merge branch 'pr-8749' into feature/win11theming/staging-mirror
dipeshmsft baa69d2
Merge branch 'pr-8750' into feature/win11theming/staging-mirror
dipeshmsft b573992
Merge branch 'pr-8751' into feature/win11theming/staging-mirror
dipeshmsft bf94ba4
Update resources on theme change
singhashish-wpf 2800fcf
Accent Updates in SystemResources.cs
harshit7962 4b94044
Refactoring accent colorization part
harshit7962 9de6b4a
Changing Accent Color and Theme
harshit7962 60efc2b
Remove use of WinDef classes
dipeshmsft 2a62200
Fix (Win11Theming): MainWindow does not load with latest system theme…
harshit7962 7a9c499
Removed symbol icon and related classes usage
dipeshmsft 4cb0b45
Removed PassiveScrollViewer
dipeshmsft 3284e77
Removed Button.CornerRadius
dipeshmsft cb0c2d3
Fix (win11theming): Delayed theme change (Optimizing theme change time)
harshit7962 be439c0
Removed Button.Appearance and introduced Accent Button Style
dipeshmsft 3191151
Made extra converters internal
dipeshmsft 5e5722e
Removing Button.Icon property
dipeshmsft d9012da
Removing TextBox.Icon property
dipeshmsft f16317f
Merge branch 'feature/win11theming/api/remove-passivescrollviewer' in…
dipeshmsft ad9a30a
Merge branch 'feature/win11theming/api/internal-converters' into feat…
dipeshmsft b93e3e8
Merge branch 'feature/win11theming/api/controls/button' into feature/…
dipeshmsft f0b850d
Merge branch 'feature/win11theming/api/remove-textboxicon' into featu…
dipeshmsft 4ccb7a2
Merge branch 'feature/win11theming/api/remove-symbolicon' into featur…
dipeshmsft e31e9c1
Enabling High Contrast Switching
harshit7962 4859511
Fix(win11theming): dark theme not working properly
harshit7962 2c7c234
Update(Win11Theming): Changing access type of non-essential methods t…
harshit7962 f2d20f9
Removed all chromes from Win11 styles
dipeshmsft d82b903
Removed SystemDropShadowChrome from Win11 style
dipeshmsft 1321dd9
Remove extra properties from PasswordBox
dipeshmsft a5777fb
Removed extra public API changes in TextBox and RichTextBox
dipeshmsft 21bb133
Made ClearButtonEnabled property internal in TextBox
dipeshmsft 567e563
Regenerated ApiCompat Baseline
dipeshmsft 527c2ea
Removed extra API compilation
dipeshmsft c7df285
Removed ContextMenu and Menu code-behind
dipeshmsft 710aa8d
Made extra methods internal in TextBox
dipeshmsft d0c2a6b
Refactor(Win11Theming): Reusing currentTheme component and minor fixes
harshit7962 cf29fef
Fix(Win11Theming): Removing unused SystemThemeManager and SystemTheme…
harshit7962 d655a61
Removed IsTextSelectionEnabled from RichTextBox
dipeshmsft 9628dd0
Making DataGridCheckboxColumn Style property internal
rchauhan18 8f70a76
Revert "Removed ContextMenu and Menu code-behind"
dipeshmsft acd65e6
Removed ContextMeny and Menu Style code behinds
dipeshmsft f34a0fd
Removed RelayCommands and WindowCornerPreference
dipeshmsft 3fefe77
Code Cleanup and Removal of ControlsDictionary
harshit7962 304d4dc
Fix(Win11Theming): Adding Opt-in for New styles and controls
harshit7962 440e0d3
Removing unused ObservedWindow class
harshit7962 09acde5
Removed FluentWindow and made WindowBackdrop internal. Fixed RTB CM
dipeshmsft 10a6ed3
Merge branch 'feature/win11theming/api/window-titlebar' into feature/…
dipeshmsft 4d7cf30
Merge branch 'feature/win11theming/api/controls/DataGrid' into featur…
dipeshmsft 018c329
Merge branch 'feature/win11theming/base-replica' into RemovingThemeMa…
harshit7962 d306464
Merge pull request #2 from harshit7962/RemovingThemeManager
harshit7962 1eed317
Fix(Win11Theming): Build Failure and High Contrast Switching
harshit7962 21f2cdf
Removing Files/Classes not being compiled
harshit7962 546df32
Remove TitleBar and FluentWindow
dipeshmsft f9c1ee9
Fix(Win11Theming): CheckBox Design Issues
harshit7962 982adfc
Merged PR 37761: Fix(Win11Theming): CheckBox Design Issues
harshit7962 37fccb6
Fixed gradient for border brush
anjali-wpf d210974
Revert "Fixed gradient for border brush"
anjali-wpf 0d3e0ec
Fix(Win11Theming): Removal of unused RDM, changing requested method n…
harshit7962 2025754
Removed extra classes and replaced FontIcon with TextBlock
dipeshmsft 42b28d6
Removed color extension and fixed CheckBox style
dipeshmsft 6891dae
Fix(Win11Theming): Discarded need for using theme dictionary i app.xa…
harshit7962 6830674
Merged PR 37802: Fix non-essential need for themedictionary declarati…
harshit7962 d1a9e9f
Removed DisplayDpi and fixed icon animations
dipeshmsft f7c82b7
Merged PR 37801: Removed extra classes from CompleteWin11Changes
dipeshmsft 9ace9bc
Remove unused styles and methods
dipeshmsft b53fea1
Fix(Win11Theming): Get Exact Accent color variations
harshit7962 7507be1
Removed references of deleted styles
dipeshmsft d32ba9b
Merged PR 37807: Get Exact values of Accent Color and it's variations.
harshit7962 60e31b1
Removed reference of the unused styles
dipeshmsft 36f5a4d
Merged PR 37804: Removed extra styles
dipeshmsft c5ba357
Removed placeholder from the controls
dipeshmsft c658803
Removed unnecessary code
dipeshmsft 60ba33b
Removed extra files and renamed AppInitNewTheme flag
dipeshmsft 3fda1ca
Fix(Win11Theming): Updated Common xaml resources to support exact acc…
harshit7962 220cd8c
Removed some files and renamed some methods
dipeshmsft f1ef9e5
Fix(Win11Theming): Accent Button incorrect styles
harshit7962 55ae8e3
Merged PR 37829: Update xaml resources for accent colors parity
harshit7962 7d9cca7
Removed some extra code from styles
dipeshmsft bf57add
Fixed calendar header font weight
anjali-wpf 7510c71
Revert "Fixed calendar header font weight"
anjali-wpf 9ec3f03
Merged PR 37832: Removed extra code and styles. Refactorings
dipeshmsft 5c94f99
Merge branch 'CompleteWin11Changes' of https://dev.azure.com/dnceng/i…
anjali-wpf 15a1d01
Merge branch 'CompleteWin11Changes' of https://dev.azure.com/dnceng/i…
anjali-wpf 761170f
Merge branch 'CompleteWin11Changes' of https://dev.azure.com/dnceng/i…
anjali-wpf 1b8aa9d
Merged PR 37840: Merging Changes from different working branch
harshit7962 174eee7
Fix(Win11Theming): ListBox Design Issues
harshit7962 73be056
Fix(Win11Theming): Progress Bar's Color Issues
harshit7962 72d9958
Fix(Win11Theming): ProgressBar Design Issues
harshit7962 8b29b60
Fixed RadioButton disabled state colour
anjali-wpf dfe8dce
Fix(Win11Design): RadioButton and Checkbox Design Issues
harshit7962 b5a0c5e
Merge pull request #6 from harshit7962/RadioButtonFix
anjali-wpf 7c4b263
Fix(Win11Theming): Checkbox Glyph Design Issues
harshit7962 cc1e0cd
Merge branch 'CompleteWin11Changes' of https://github.com/harshit7962…
anjali-wpf 2397581
Merge pull request #7 from harshit7962/fixRbIssues
harshit7962 5ce9ad3
Candidate Fix for Button Design Issues
harshit7962 6152df8
Merge pull request #5 from harshit7962/fixDesignIssues
harshit7962 d411d53
Fix(Win11Theming): Removing Extra Border
harshit7962 5d0d015
Merge pull request #8 from harshit7962/fixRBIssues
harshit7962 5271cca
Fix(Win11Theming): Dark accent button background color
harshit7962 ab9ddc1
Fix(Win11Theming): Disbaled Button Design Issues
harshit7962 2fd060c
Extended application based theme switching
harshit7962 0a52f8f
Merge pull request #10 from harshit7962/fixThemeDetection
harshit7962 bdfee86
Merge pull request #9 from harshit7962/fixButtonDesign
harshit7962 f04eba8
Updating Theming Name
harshit7962 fa1f447
Merge branch 'CompleteWin11Changes' into nameChange
harshit7962 63f1bce
Merge pull request #11 from harshit7962/nameChange
harshit7962 059c156
Updating Theme name
harshit7962 f2d1261
Merge pull request #12 from harshit7962/nameChange
harshit7962 74f82c6
Fix: Dictionary paths
harshit7962 594a325
Remove hard-coded reference
harshit7962 f75e2f0
Removing unused Acrylic References
harshit7962 a09e5c5
Merge pull request #13 from harshit7962/removingUnusedReferences
harshit7962 fae66a2
Unsubscribing the Loaded handler for applying window backdrop and gla…
harshit7962 9664bf0
Update src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Wind…
harshit7962 e3a9783
Fixing ProgressBar's incorrect brush assignment
harshit7962 5cf9a11
Adding a fallback if appsuselightthemekey is not present
harshit7962 6f1f45c
Replacing the highcontrast detection
harshit7962 cd28c95
Merge pull request #17 from harshit7962/resolvingPRComments
harshit7962 efeb796
Addressing PR Review Comments :
dipeshmsft 6251c72
Merge pull request #18 from harshit7962/win11theming/dipesh-pr-commen…
dipeshmsft abc5caf
Change : Removed Dwmapi.cs and merged it with NativeMethods
dipeshmsft c2e0851
Merge pull request #18 from harshit7962/win11theming/dipesh-pr-commen…
dipeshmsft dbd9da1
Removing fallback accent color variation calculation logic and assign…
harshit7962 600fe25
Merge pull request #20 from harshit7962/removeFallbackColor
harshit7962 b70db29
Merge pull request #19 from harshit7962/win11theming/dipesh-pr-commen…
dipeshmsft 9bef002
Refactoring WindowBackdrop and removing undocumented APIs (#21)
dipeshmsft 6503a5c
Merge branch 'CompleteWin11Changes' into UnsubscribingLoadedEvent
harshit7962 6f209f9
Merge pull request #16 from harshit7962/UnsubscribingLoadedEvent
harshit7962 e17f516
Removing unused dwColorSetIndex and updating default value of dwmValue
harshit7962 aa1c92a
Changing GetColorFromPreference arguments
harshit7962 640a235
Changing the system accent color to get value from IMCLR_SystemAccent
harshit7962 712b6e4
Fixing Typo
harshit7962 3e41329
Addressing Review Comments - Part 4 (#23)
dipeshmsft 64db379
Merge branch 'CompleteWin11Changes' into fixingPRComments
harshit7962 8fe505a
Merge pull request #24 from harshit7962/fixingPRComments
harshit7962 d766f8b
Fix Border Highlight color on focus
harshit7962 f121d0a
Fix Progress Bar Tracker Height and Color Issues
harshit7962 ec0867d
Update Accent color for some controls in Dark mode
rchauhan18 f1832f6
Fix MenuFlyout Issues
harshit7962 89d9f14
Merge pull request #28 from harshit7962/fixDesignIssues1
harshit7962 8b3030b
Merge branch 'CompleteWin11Changes' into FixDesignAccentColor
harshit7962 569454d
Merge pull request #27 from harshit7962/FixDesignAccentColor
harshit7962 053209b
Slider accent color and ticks fix
dipeshmsft 085f316
Fixes review comments - Refactoring (#25)
dipeshmsft ca5d6d8
Renamed style names (#40)
harshit7962 50c1cef
ListBox and Slider Design Fix (#41)
harshit7962 1dbffb6
Updating OS version check (#42)
rchauhan18 93a09dd
Removed extra MenuItem styles (#43)
dipeshmsft 78a9f06
Made Font Names Dynamic (#45)
dipeshmsft f1a6fb1
Removed TextBlock Style (#44)
dipeshmsft 3ae58a1
Modified control elevation brush and button style (#46)
dipeshmsft e8459cd
Fix control elevation brush (#47)
dipeshmsft b7a943a
Renaming the theme to Fluent (#38)
harshit7962 fed3410
Merge branch 'main' into CompleteWin11Changes
dipeshmsft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
...rosoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Appearance/ApplicationTheme.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
// This Source Code Form is subject to the terms of the MIT License. | ||
// If a copy of the MIT was not distributed with this file, You can obtain one at https://opensource.org/licenses/MIT. | ||
// Copyright (C) Leszek Pomianowski and WPF UI Contributors. | ||
// All Rights Reserved. | ||
|
||
namespace System.Windows.Appearance; | ||
|
||
/// <summary> | ||
/// Theme in which an application using WPF UI is displayed. | ||
/// </summary> | ||
internal enum ApplicationTheme | ||
{ | ||
/// <summary> | ||
/// Unknown application theme. | ||
/// </summary> | ||
Unknown, | ||
|
||
/// <summary> | ||
/// Dark application theme. | ||
/// </summary> | ||
Dark, | ||
|
||
/// <summary> | ||
/// Light application theme. | ||
/// </summary> | ||
Light, | ||
|
||
/// <summary> | ||
/// High contract application theme. | ||
/// </summary> | ||
HighContrast | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling this "Fluent Windows" as the theme name is a divergence from WinUI I think. "Windows" also seems unnecessary as WPF only runs on Windows Desktop anyway (the Microsoft version).
Fluent v1: Windows 10 (which probably should have been included some time ago separately https://github.com/Kinnara/ModernWpf)
Fluent v2: Windows 11 and what this theme is based on.
The name for this theme should be "Fluent2" which has precedent: Aero2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dipeshmsft Using "Fluent" is definitely better now. However, I'm curious why you didn't go with the technically correct name "Fluent2"?
If there is ever a "Fluent3" variation there might be a problem as you are faced with:
-> Using Fluent2 name in WPF for WinUI's Fluent3 (off by one is confusing)
-> Just updating Fluent to the latest and don't worry about the name (is breaking for apps depending on how much the styles change so is frowned upon)
-> Renaming this theme to Fluent2 and then have a side-by-side Fluent3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that Windows is redundant here. We have changed the name to Fluent now. As we don't already have a Fluent version, Fluent2 may create confusion. We are still discussing the API proposal for Theme switching, where we will be discussing the names and we can rediscuss it with the API proposal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dipeshmsft Ok, thanks for the clarification. Skipping just "Fluent" may indeed raise some questions to users.
Also note that it would theoretically be possible for a community member to contribute a Fluent (version 1) in the future (but not sure if you would allow resources for that as it's obsolete). So that would be a naming collision in that case. Just another thought here.