Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Fluent Styles #9171

Closed
wants to merge 4 commits into from
Closed

Conversation

harshit7962
Copy link
Member

@harshit7962 harshit7962 commented May 29, 2024

Fixes #8698

Description

Multiple styles are not specifically added to Fluent styles. Currently, Fluent styles are not individually incorporated. They are overlaid on the Aero2 theme, which allows the newly added controls to remain visible, although in older styles. However, this approach will not be sustainable when Fluent styles are loaded directly. This could lead to unforeseen behavior when interacting with the controls.
Following styles are added in this PR:

  1. BrowserWindow
  2. CollectionViewGroup (Additional Styling Not Needed)
  3. ContentControl (Additional Styling Not Needed)
  4. Floating DataGrid Column (in controls.xaml)
  5. DocumentViewer (Additional Styling Needed in some parts)
  6. GridSplitter
  7. GroupBox
  8. GroupItem (Additional Styling Not Needed)
  9. HeaderedContentControl (Additional Styling Not Needed)
  10. Hyperlink
  11. ItemsControl
  12. NavigationWindow
  13. ResizeGrip
  14. Thumb
  15. UserControl
  16. GridViewColumnHeader
  17. StatusBarItem

Testing

Local Build Pass
Gallery Application Testing

Risk

A few of the above styles are not in accordance with Windows 11 styling (the ones not marked with Additional styling not needed). They need to be upgraded at a later stage.

Microsoft Reviewers: Open in CodeFlow

@harshit7962 harshit7962 added this to the 9.0.0 milestone May 29, 2024
@harshit7962 harshit7962 requested a review from a team as a code owner May 29, 2024 04:25
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label May 29, 2024
@harshit7962 harshit7962 requested a review from a team as a code owner July 18, 2024 07:16
@dipeshmsft dipeshmsft self-assigned this Aug 5, 2024
@dipeshmsft dipeshmsft modified the milestones: 9.0.0, Future Aug 5, 2024
@harshit7962
Copy link
Member Author

Closing this as of now as any of these controls that could have been added as is in Fluent are added via another PR and other controls might need changes to their template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR metadata: Label to tag PRs, to facilitate with triage Win 11 Theming
Projects
Status: ☑ Done
Development

Successfully merging this pull request may close these issues.

Missing Control Styles in Windows 11 Themes
2 participants