Remove Marshal Exception/HRESULT proxies from SecurityHelper, simplify code #9977
+32
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continues the work on removing CAS remnants, this time again method proxies and "helpers" from
SecurityHelper.In this PR we remove
GetHRForExceptionfromStreamAsIStreamalong with obsolete warning suppresions and alsoGetExceptionForHRplusThrowExceptionForHRproxies._lastExceptionwas just storing the latest exception in a private field that was never read.COR_E_OBJECTDISPOSEDin some cases instead of setting up a frame, conditionally throwingObjectDisposedException, catching it just to retrieve theHResultand then returning it but I think it is out of scope for this PR.Customer Impact
Decreased size of assemblies, cleaner codebase for developers.
Regression
No.
Testing
Local build.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow