-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(Drawer): add ZIndex parameter documentation #5398
Conversation
Reviewer's Guide by SourceryThis pull request adds documentation for the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please ensure the new documentation is clear and concise for users to understand the purpose and usage of the
ZIndex
parameter. - Verify that the added documentation aligns with the actual behavior and implementation of the
ZIndex
parameter in the Drawer component.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5398 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 645 645
Lines 29276 29276
Branches 4135 4135
=========================================
Hits 29276 29276 ☔ View full report in Codecov by Sentry. |
add ZIndex parameter documentation
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5397
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
This pull request adds documentation for the
ZIndex
parameter of the Drawer component and clarifies how to close the Drawer component from code.Documentation:
ZIndex
parameter of the Drawer component, explaining how to adjust the z-index to prevent it from being obscured by other popups.DialogCloseButton
and theOnCloseAsync
callback method.