-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(JuHeIpLocatorProvider): add JuHeIpLocatorProvider package #5404
Conversation
# Conflicts: # src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj # src/BootstrapBlazor.Server/Extensions/ServiceCollectionSharedExtensions.cs
Reviewer's Guide by SourceryThis pull request removes the default registration of Updated class diagram for BootstrapBlazorServiceCollectionExtensionsclassDiagram
class IServiceCollection {
+AddBootstrapBlazorJuHeIpLocatorService()
}
class JuHeIpLocatorProvider
IServiceCollection -- JuHeIpLocatorProvider : Adds
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like the tests for
JuHeIpLocatorProvider
have been removed fromUnitTest/Services/IpLocatorTest.cs
- were these moved elsewhere? - The
JuHeIpLocatorProvider
is no longer registered directly inBootstrapBlazorServiceCollectionExtensions.cs
- is it now registered via the extension method inServiceCollectionSharedExtensions.cs
?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5404 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 645 644 -1
Lines 29280 29250 -30
Branches 4135 4130 -5
=========================================
- Hits 29280 29250 -30 ☔ View full report in Codecov by Sentry. |
add JuHeIpLocatorProvider package
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5403
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
This pull request introduces the JuHe IP Locator Provider, enabling IP address geolocation using the JuHe service. It also removes the JuHe IP Locator Provider from the core BootstrapBlazor project and adds it to the BootstrapBlazor.Server project.
New Features:
Enhancements:
Tests: