Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(JuHeIpLocatorProvider): add JuHeIpLocatorProvider package #5404

Merged
merged 22 commits into from
Feb 20, 2025

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Feb 20, 2025

add JuHeIpLocatorProvider package

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5403

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

This pull request introduces the JuHe IP Locator Provider, enabling IP address geolocation using the JuHe service. It also removes the JuHe IP Locator Provider from the core BootstrapBlazor project and adds it to the BootstrapBlazor.Server project.

New Features:

  • Adds the JuHe IP Locator Provider to the application, allowing the application to determine the geographical location of IP addresses using the JuHe service.

Enhancements:

  • Registers the JuHe IP Locator service within the application's service collection, making it available for dependency injection.

Tests:

  • Removes the tests associated with the JuHe IP Locator Provider, as the provider itself has been removed from the core BootstrapBlazor project.

Copy link

sourcery-ai bot commented Feb 20, 2025

Reviewer's Guide by Sourcery

This pull request removes the default registration of JuHeIpLocatorProvider and introduces an extension method for registering it as a service.

Updated class diagram for BootstrapBlazorServiceCollectionExtensions

classDiagram
  class IServiceCollection {
    +AddBootstrapBlazorJuHeIpLocatorService()
  }
  class JuHeIpLocatorProvider

  IServiceCollection -- JuHeIpLocatorProvider : Adds
Loading

File-Level Changes

Change Details Files
Removed JuHeIpLocatorProvider as a default service.
  • Removed the registration of JuHeIpLocatorProvider as a singleton service.
src/BootstrapBlazor/Extensions/BootstrapBlazorServiceCollectionExtensions.cs
Removed JuHeIpLocatorProvider related tests.
  • Removed JuHeIpLocatorProvider_Ok test.
  • Removed MockProviderJuHeFetchError mock class.
  • Removed MockJuHeNullProvider mock class.
  • Removed MockJuHeFailProvider mock class.
  • Removed MockJuHeProvider mock class.
  • Removed MockJuHeFailedProvider mock class.
  • Removed JuHe_Section_Error test.
  • Removed JuHe related asserts in Fetch_Error and Fetch_Result_Fail tests.
test/UnitTest/Services/IpLocatorTest.cs
Removed JuHeIpLocatorProvider class.
  • Deleted the JuHeIpLocatorProvider.cs file.
src/BootstrapBlazor/Services/IPLocator/JuHeIpLocatorProvider.cs
Added extension method for registering JuHe IP Locator service.
  • Added AddBootstrapBlazorJuHeIpLocatorService extension method to IServiceCollection.
src/BootstrapBlazor.Server/Extensions/ServiceCollectionSharedExtensions.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5403 Add the JuHeIpLocatorProvider package to the project.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Feb 20, 2025
@bb-auto bb-auto bot added this to the v9.3.0 milestone Feb 20, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Feb 20, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It looks like the tests for JuHeIpLocatorProvider have been removed from UnitTest/Services/IpLocatorTest.cs - were these moved elsewhere?
  • The JuHeIpLocatorProvider is no longer registered directly in BootstrapBlazorServiceCollectionExtensions.cs - is it now registered via the extension method in ServiceCollectionSharedExtensions.cs?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (75897ad) to head (804f6d5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5404   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          645       644    -1     
  Lines        29280     29250   -30     
  Branches      4135      4130    -5     
=========================================
- Hits         29280     29250   -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 02c2186 into main Feb 20, 2025
6 checks passed
@ArgoZhang ArgoZhang deleted the refactor-juhe branch February 20, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(JuHeIpLocatorProvider): add JuHeIpLocatorProvider package
1 participant