Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ListView): use grid layout instead of flex #5409

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Feb 21, 2025

use grid layout instead of flex

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5408

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Replaced the flex layout with a grid layout for the ListView component to improve responsiveness and simplify the layout structure.

Copy link

sourcery-ai bot commented Feb 21, 2025

Reviewer's Guide by Sourcery

The ListView component was refactored to use a grid layout instead of flex layout to improve responsiveness and simplify the layout structure.

Updated class diagram for ListView component

classDiagram
  class ListView {
    -string? BodyClassString
    +RenderFragment RenderItem((object? GroupName, IOrderedEnumerable<TItem> Items) key, int index)
    +RenderFragment<IEnumerable<TItem>> RenderGroup
  }
  note for ListView "ListView component using grid layout instead of flex layout"
Loading

File-Level Changes

Change Details Files
Replaced flex layout with grid layout for the ListView component.
  • Updated the ListView component to use a grid layout instead of flex layout for displaying items.
  • Adjusted CSS styles to accommodate the grid layout, including removing flex-related properties and adding grid-specific properties.
  • Modified the Razor component to render items within a grid container.
  • Updated the spacing and padding variables to better suit the grid layout.
src/BootstrapBlazor/Components/ListView/ListView.razor.scss
src/BootstrapBlazor/Components/ListView/ListView.razor
src/BootstrapBlazor.Server/Components/Samples/ListViews.razor
src/BootstrapBlazor/wwwroot/scss/theme/bootstrapblazor.scss
src/BootstrapBlazor.Server/Components/Samples/ListViews.razor.css
src/BootstrapBlazor/Components/ListView/ListView.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5408 Replace the flex layout in the ListView component with a grid layout.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Feb 21, 2025
@bb-auto bb-auto bot added this to the v9.3.0 milestone Feb 21, 2025
@ArgoZhang ArgoZhang enabled auto-merge (squash) February 21, 2025 00:27
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a CSS class to the ListView component to allow users to opt-out of the grid layout.
  • The commit message should be updated to be in English.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (02c2186) to head (f9dd6d3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5409   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          644       644           
  Lines        29250     29330   +80     
  Branches      4130      4128    -2     
=========================================
+ Hits         29250     29330   +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit e1a8f53 into main Feb 21, 2025
6 checks passed
@ArgoZhang ArgoZhang deleted the feat-listview branch February 21, 2025 00:30
ArgoZhang added a commit that referenced this pull request Feb 22, 2025
ArgoZhang added a commit that referenced this pull request Feb 22, 2025
* Revert "feat(ListView): use grid layout instead of flex (#5409)"

This reverts commit e1a8f53.

* refactor: 更改方法名称

* refactor: 代码复用

* refactor: 更新滚动条样式
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(ListView): use grid layout instead of flex
1 participant