-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DateTimeRange): should be reset Value after close pop-up #5413
Conversation
Reviewer's Guide by SourceryThis PR fixes issue #5383 by adding a callback to reset the DateTimeRange and DateTimePicker components when the pop-up is closed. This ensures that the component's value is properly reset after the pop-up is closed. Sequence diagram for DateTimeRange pop-up closesequenceDiagram
participant JS
participant DateTimeRange
JS->>DateTimeRange: Pop-up closed
activate DateTimeRange
DateTimeRange->>DateTimeRange: TriggerHideCallback()
DateTimeRange->>DateTimeRange: ResetBodyValue()
DateTimeRange->>DateTimeRange: StateHasChanged()
deactivate DateTimeRange
Sequence diagram for DateTimePicker pop-up closesequenceDiagram
participant JS
participant DateTimePicker
JS->>DateTimePicker: Pop-up closed
activate DateTimePicker
DateTimePicker->>DateTimePicker: TriggerHideCallback()
DateTimePicker->>DateTimePicker: StateHasChanged()
deactivate DateTimePicker
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider debouncing the
StateHasChanged
call inTriggerHideCallback
to avoid excessive re-rendering. - The javascript file
DateTimePicker/DateTimePicker.razor.js
was copied instead of creating a new one forDateTimeRange
.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5413 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 644 644
Lines 29330 29350 +20
Branches 4129 4129
=========================================
+ Hits 29330 29350 +20 ☔ View full report in Codecov by Sentry. |
Co-Authored-By: Jiří Vokřínek <[email protected]>
@sourcecy-ai review |
should be reset Value after close pop-up
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5383
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Fixes an issue where the DateTimeRange component was not properly resetting its value after the popup was closed. This is achieved by adding a JavaScript callback function that is triggered when the popup is closed, and then resetting the component's value.
Bug Fixes:
Enhancements:
Tests: