Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic admin UI to create, edit and generate new door codes #598

Merged
merged 4 commits into from
Dec 11, 2021

Conversation

anaulin
Copy link
Member

@anaulin anaulin commented Dec 11, 2021

As part of the work in #594 to support the new door code workflows, this PR adds some UIs for admins to administer door codes, including:

  • see all existing door codes and their statuses
  • edit an existing door code (this includes assigning a door code to a user)
  • manually enter a new door code in the database
  • autogenerate 10 new unique door codes

Screenshots of the new UIs:

Screen Shot 2021-12-10 at 5 59 01 PM

Screen Shot 2021-12-10 at 5 59 11 PM

Screen Shot 2021-12-10 at 5 59 28 PM

@anaulin anaulin requested review from brittag and compwron December 11, 2021 02:01
@brittag
Copy link
Member

brittag commented Dec 11, 2021

I haven't tried this locally yet, but the screenshots look pretty good to me! Would we give the formerly_assigned_in_lock status to codes that we previously created in the lock (and presumably assigned) and have deleted from the lock?

@anaulin
Copy link
Member Author

anaulin commented Dec 11, 2021

Yes, the intent for the "formerly_assigned..." statuses is to support the workflow where we un-assign a code from a member, but we need to mark somehow that someone needs to remove it from the lock. Once it is removed from the lock, we still want to keep it in the database to avoid reuse.

We can refine all of this as we figure out the precise workflows.

@anaulin
Copy link
Member Author

anaulin commented Dec 11, 2021

I'm going to merge this, so that I can deploy it and we can start trying to feel it out and properly test it.

@anaulin
Copy link
Member Author

anaulin commented Dec 11, 2021

Happy to address any comments or issues in follow-up PRs, if anyone sees something.

@anaulin anaulin merged commit 10835fe into main Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants