Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Multi-step forms #1167

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

bgilhome-now
Copy link
Contributor

@bgilhome-now bgilhome-now commented May 16, 2024

Issue:
This is a WIP PR to demonstrate a basic integration of multi-step forms, using the Webform element type webform_wizard_page in the backend and @formkit/addons in the frontend. Basic styling is added by the frontend package, as well as step navigation & validation indicators.

Implements: #1170

What I did

  • Added @formkit/addons package
  • Mapped backend webform_wizard_page element type to the addon's step Formkit type
  • Un-nested step form data in the submitHandler for RplForm

How to test

  • Enable the 'Wizard page' Webform element type in the backend at /admin/structure/webform/config/elements
  • Create a test webform using the wizard page element & place it on a test landing page
  • Update frontend packages ripple-ui-forms & ripple-tide-webform to use this branch
  • Run dev on the frontend and view the test landing page
  • Confirm form steps are shown and form data submits correctly

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@bgilhome-now bgilhome-now mentioned this pull request May 16, 2024
4 tasks
@dylankelly dylankelly added the Proposal - Draft New feature proposal label May 16, 2024
@waitingallday
Copy link
Member

Might be possible to implement this with #1236

@bgilhome-now bgilhome-now marked this pull request as ready for review July 19, 2024 07:13
@bgilhome-now bgilhome-now changed the title WIP: feature request: Multi-step forms Feature request: Multi-step forms Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposal - Draft New feature proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants