Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatDate, add more unit tests #1378

Open
wants to merge 1 commit into
base: release/2.21.0
Choose a base branch
from

Conversation

waitingallday
Copy link
Member

Issue:

What I did

How to test

  • Added unit tests for formatDate and distanceAsPercentage

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@waitingallday waitingallday self-assigned this Nov 13, 2024
@waitingallday waitingallday added this to the 2.21.0 milestone Nov 13, 2024
Copy link

cypress bot commented Nov 13, 2024

ripple-framework    Run #2375

Run Properties:  status check passed Passed #2375  •  git commit 326c23c071: fix(@dpc-sdp/ripple-ui-core): :bug: improve formatDate, add more unit tests
Project ripple-framework
Branch Review fix/format-date-options
Run status status check passed Passed #2375
Run duration 09m 16s
Commit git commit 326c23c071: fix(@dpc-sdp/ripple-ui-core): :bug: improve formatDate, add more unit tests
Committer Jason Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 211
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant