forked from KatLands/dnd-bot
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pymongo with Mongo Engine #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop leaving magic variables scattered all over the place and start using constants
This introduces a bit more consistency since we're not individually recreating the same variables
Allows us to start replacing hard pymongo implementation with an ORM for better abstraction
Turns out sqlalchemy doesn't work for document based databases
dragid10
force-pushed
the
sqlalchemize
branch
from
November 22, 2023 02:04
063611e
to
48327f2
Compare
This is replaced by the db_client since we're using MongoEngine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to make maintenance easier, we're going to start using an Object Document Manager (ODM) called MongoEngine to make calls to the mongodb easier
Motivation and Context
This change will enable us to make updates to the bot easier in the future. Python native objects make it a lot easier to add features hitting the database
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: