Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use black_box when running benchmarks to avoid compiler constant folding #18

Closed

Conversation

AngelicosPhosphoros
Copy link
Contributor

No description provided.

@dragostis
Copy link
Owner

Thanks for the PR! black_box in these benchmarks doesn't seem to be needed since the result of the computation can't simply be discarded since it's used in the assert.

I'm going to close this PR, but feel free to re-open if you think that the current benchmarks are inaccurate in any way.

@dragostis dragostis closed this Oct 9, 2024
@AngelicosPhosphoros AngelicosPhosphoros deleted the use_black_box branch October 9, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants