Updated Lagoon deployment script to use long-form options. #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1369 +/- ##
========================================
Coverage 67.49% 67.49%
========================================
Files 41 41
Lines 3046 3046
========================================
Hits 2056 2056
Misses 990 990 ☔ View full report in Codecov by Sentry. |
AlexSkrypnyk
force-pushed
the
feature/update-lagoon-deployment-flags
branch
from
0c33fe0 to
124522e
Compare
AlexSkrypnyk
force-pushed
the
feature/update-lagoon-deployment-flags
branch
from
124522e to
ba120a9
Compare
AlexSkrypnyk
force-pushed
the
feature/update-lagoon-deployment-flags
branch
from
ba120a9 to
995d753
Compare
AlexSkrypnyk
force-pushed
the
feature/update-lagoon-deployment-flags
branch
from
995d753 to
5c764e9
Compare
| @@ -63,7 +63,7 @@ load _helper.deployment.bash | |||
|
|
|||
| # Make sure that one of the excluded directories will be ignored in the | |||
| # deployment artifact. | |||
| mkdir -p "${SRC_DIR}"/web/themes/custom/star_wars/node_modules | |||
| mkdir --project "${SRC_DIR}"/web/themes/custom/star_wars/node_modules | |||
There was a problem hiding this comment.
This doesnt make sense
mkdir -p makes directory and all intermediate directories nothing to do with --project
AlexSkrypnyk
force-pushed
the
feature/update-lagoon-deployment-flags
branch
from
5c764e9 to
e265e5e
Compare
richardgaunt
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.