Add flag to increase verbosity and flag to override unreachable state #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also added tests for TLS options
- I refactored the Nagios helper a bit to integrate this functionality a bit simpler. Before we had distinct methods on the helper that added warn,crit,unko message, now there's a general method that takes an int as parameter. This way we avoid if-else structures for the new functionality.
… precisely - Before we only had a boolean debug flag, good for debugging errors. The verbose flag can be used more precisely (`-v -vvv`) to specify when something should be printed. This is useful for adding more output whilst avoiding full debug output that contains secrets.
This was referenced Apr 9, 2024
|
Currently testing this and waiting for some third party feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following features:
Add verbose flag and function that can be used to enhance output more precisely
Before we only had a boolean debug flag, good for debugging errors.
The verbose flag can be used more precisely (
-v -vvv) to specify whensomething should be printed. This is useful for adding more output whilst avoiding
full debug output that contains secrets.
Fixes #83
Add flag to override URL unreachable state
I refactored the Nagios helper a bit to integrate this functionality a bit simpler.
Before we had distinct methods on the helper that added warn,crit,unko message, now
there's a general method that takes an int as parameter.
This way we avoid if-else structures for the new functionality.
Fixes #82
Plus I refactored the main function to be a bit leaner and added tests for the TLS options