Failing test for UK VAT numbers

driesvints · May 25, 2021 · 6e674e4 · 6e674e4
1 parent 4cee16e
commit 6e674e4
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/Mpociot/VatCalculator/VatCalculator.php b/src/Mpociot/VatCalculator/VatCalculator.php
@@ -699,7 +699,7 @@ public function getVATDetails($vatNumber)
 
             $response = json_decode($result, true, 512, JSON_OBJECT_AS_ARRAY);
 
-            if (isset($response['code']) && $response['code'] === 'NOT_FOUND') {
+            if (isset($response['code'])) {
                 return false;
             }
 

diff --git a/tests/VatCalculatorTest.php b/tests/VatCalculatorTest.php
@@ -497,6 +497,24 @@ public function testCanValidateValidUKVATNumber()
         $this->assertTrue($result);
     }
 
+    public function testCanValidateInvalidUKVATNumber()
+    {
+        $config = m::mock('Illuminate\Contracts\Config\Repository');
+
+        $config->shouldReceive('has')
+            ->once()
+            ->with('vat_calculator.business_country_code')
+            ->andReturn(false);
+
+        $result = new \stdClass();
+        $result->valid = true;
+
+        $vatNumber = 'GB Invalid';
+        $vatCalculator = new VatCalculator($config);
+        $result = $vatCalculator->testing()->isValidVATNumber($vatNumber);
+        $this->assertFalse($result);
+    }
+
     /**
      * @link https://tools.tracemyip.org/search--country/germany
      */