Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded to rector/rector:^0.19.0 #169

Merged
merged 2 commits into from
Jan 11, 2024
Merged

upgraded to rector/rector:^0.19.0 #169

merged 2 commits into from
Jan 11, 2024

Conversation

asugai
Copy link
Contributor

@asugai asugai commented Jan 9, 2024

Updated all references per https://github.com/rectorphp/rector/releases/tag/0.19.0

-use Rector\Core\
+use Rector\

@GeniJaho
Copy link
Collaborator

GeniJaho commented Jan 9, 2024

@asugai Thanks for the PR 😄

I think you need to run ./vendor/bin/duster to fix the Code Analysis issues.
Also, to make the PHPStan errors go away, you need to update the phpstan.neon file to replace the ignored errors for Rector\\Core\\Contract\\Rector\\RectorInterface and Rector\\Core\\Reflection\\ReflectionResolver.

Thank you ✌️

@asugai
Copy link
Contributor Author

asugai commented Jan 11, 2024

hey @GeniJaho - just saw these and applied the fixes

@driftingly
Copy link
Owner

@asugai Sorry, one last change, can you also update the Rector requirement here:
https://github.com/driftingly/rector-laravel/blob/main/build/composer-php-72.json

Thanks 🙌

@driftingly driftingly merged commit fc6f6b8 into driftingly:main Jan 11, 2024
5 checks passed
@driftingly
Copy link
Owner

Thanks @asugai for your work on this 🙏
I'll clean up in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants