-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ResponseHelperCallToJsonResponseRector #252
Conversation
src/Rector/MethodCall/ResponseHelperCallToJsonResponseRector.php
Outdated
Show resolved
Hide resolved
src/Rector/MethodCall/ResponseHelperCallToJsonResponseRector.php
Outdated
Show resolved
Hide resolved
tests/Rector/FuncCall/RemoveRedundantWithCallsRector/Fixture/fixture.php.inc
Outdated
Show resolved
Hide resolved
...ll/RemoveRedundantWithCallsRector/Fixture/skips_calls_with_callables_as_a_second_arg.php.inc
Outdated
Show resolved
Hide resolved
4756e0b
to
4806512
Compare
4806512
to
09651c1
Compare
tests/Rector/MethodCall/ResponseHelperCallToJsonResponseRector/config/configured_rule.php
Outdated
Show resolved
Hide resolved
It might be better to scale this up to be a rule to handle all response helper scenarios. Or to make a new configurable rule for the main rector repo. |
I don't think it's possible to add them all under one configurable rule, I suspect other
A new @peterfox so how do you want to handle this PR? 😅 |
@GeniJaho I think for now it's not a bad rule. Let's get it in and then if we find it doesn't scale we'll deprecate this for something else. |
No description provided.