chore: removed migrator from the list as not needed #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @peterfox. There may be more aliases like this but I wasn't - sure it's a general issue or of my project! As it's merged I'll try to check others! If you are already on it then let me know! |
|
@MrPunyapal a few get through the net sadly. I haven't got much time for checking them currently. It would be great if you find further ones and PR them please 🙂 |
|
You can count on me @peterfox 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#293
The Migrator instance is not bound to the class name in the IoC container, it is bound to the migrator alias. I guess it should not be updated.
https://github.com/laravel/framework/blob/11.x/src/Illuminate/Database/MigrationServiceProvider.php#L80