Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed all classes which are not bounded to container #297

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

MrPunyapal
Copy link
Contributor

@MrPunyapal MrPunyapal commented Jan 16, 2025

All these classes are not bound to the container and their aliases are only bound to the container.

How do I find them all?

I just added this list to the test and removed one by one that was failing.

app(\Illuminate\Contracts\Events\Dispatcher::class); // app('events');
app(\Illuminate\Contracts\Config\Repository::class); // app('config');
app(\Psr\Log\LoggerInterface::class); // app('log');
app(\Illuminate\Routing\Router::class); // app('router');
app(\Illuminate\Contracts\Routing\UrlGenerator::class); // app('url');
app(\Illuminate\Routing\Redirector::class); // app('redirect');
app(\Illuminate\Contracts\Auth\Factory::class); // app('auth');
app(\Illuminate\Auth\SessionGuard::class); // app('auth.driver');
app(\Illuminate\Cookie\CookieJar::class); // app('cookie');
app(\Illuminate\Database\Connectors\ConnectionFactory::class); // app('db.factory');
app(\Illuminate\Database\ConnectionResolverInterface::class); // app('db');
app(\Illuminate\Database\ConnectionInterface::class); // app('db.connection');
app(\Illuminate\Database\Schema\SQLiteBuilder::class); // app('db.schema');
app(\Illuminate\Database\DatabaseTransactionsManager::class); // app('db.transactions');
app(\Illuminate\Encryption\Encrypter::class); // app('encrypter');
app(\Illuminate\Filesystem\Filesystem::class); // app('files');
app(\Illuminate\Contracts\Filesystem\Factory::class); // app('filesystem');
app(\Illuminate\Session\SessionManager::class); // app('session');
app(\Illuminate\Contracts\Session\Session::class); // app('session.store');
app(\Illuminate\Contracts\View\Factory::class); // app('view');
app(\Illuminate\View\ViewFinderInterface::class); // app('view.finder');
app(\Illuminate\View\Compilers\CompilerInterface::class); // app('blade.compiler');
app(\Illuminate\View\Engines\EngineResolver::class); // app('view.engine.resolver');
app(\Monolog\Logger::class); // app('flare.logger');
app(\Illuminate\Contracts\Cache\Factory::class); // app('cache');
app(\Illuminate\Cache\Repository::class); // app('cache.store');
app(\Illuminate\Cache\MemcachedConnector::class); // app('memcached.connector');
app(\Illuminate\Queue\QueueManager::class); // app('queue');
app(\Illuminate\Contracts\Queue\Queue::class); // app('queue.connection');
app(\Illuminate\Queue\Worker::class); // app('queue.worker');
app(\Illuminate\Queue\Listener::class); // app('queue.listener');
app(\Illuminate\Queue\Failed\DatabaseUuidFailedJobProvider::class); // app('queue.failer');
app(\Illuminate\Database\Migrations\MigrationRepositoryInterface::class); // app('migration.repository');
app(\Illuminate\Database\Migrations\MigrationCreator::class); // app('migration.creator');
app(\Illuminate\Support\Composer::class); // app('composer');
app(\Illuminate\Hashing\HashManager::class); // app('hash');
app(\Illuminate\Contracts\Hashing\Hasher::class); // app('hash.driver');
app(\Illuminate\Contracts\Mail\Factory::class); // app('mail.manager');
app(\Illuminate\Mail\Mailer::class); // app('mailer');
app(\Illuminate\Contracts\Auth\PasswordBrokerFactory::class); // app('auth.password');
app(\Illuminate\Contracts\Auth\PasswordBroker::class); // app('auth.password.broker');
app(\Illuminate\Contracts\Pipeline\Pipeline::class); // app('pipeline');
app(\Illuminate\Contracts\Redis\Factory::class); // app('redis');
app(\Illuminate\Contracts\Translation\Loader::class); // app('translation.loader');
app(\Illuminate\Contracts\Translation\Translator::class); // app('translator');
app(\Illuminate\Validation\DatabasePresenceVerifier::class); // app('validation.presence');
app(\Illuminate\Contracts\Validation\Factory::class); // app('validator');
app(\Laravel\Tinker\Console\TinkerCommand::class); // app('command.tinker');

@MrPunyapal
Copy link
Contributor Author

Here you go @peterfox 🫡

@peterfox
Copy link
Collaborator

Awesome work @MrPunyapal 😄 Thank you for doing this.

@peterfox peterfox merged commit 6b32c5f into driftingly:main Jan 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants