[MySQL]: Release connection from pool in iterator() rather than close
#4127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reecefenwick
force-pushed
the
fix/iterator-release-pooled-conn
branch
from
ef58057 to
49554f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2143 with select iterators with trivial fix to release the borrowed connection from the pool rather than attempt to destroy it
I did try to add some test coverage but couldn't find away to effectively verify the release vs end behaviour, especially consider
.end()is an alias for.release(). It does however remove the warning ensuring this code won't regress with future versions ofmysql2