[pg] fix int8 precision loss in relations (bigint, bigserial and custom int8) #4166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om int8) Fixes a bug where bigint was serialized as number in relation, losing precision. Native bigserial and bigint types are automatically casted to string. Allows custom int8 types to also be casted via `castInRelation: 'text'`. Added tests for native and custom types, with `one` and `many` relations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bigintwas serialized asnumberin relation, losing precision.bigserialandbiginttypes are automatically casted totext.castInRelation: 'text'.oneandmanyrelations.There are probably edge cases not covered, my understanding of drizzle's internals being limited.
Related (pg) : #3267, #813
Related (other dialect) : #1688