Add number mode for numeric/decimal column types #4220
+585
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louneskmt
force-pushed
the
numeric-number-mode
branch
from
126ae1e to
c9984c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
numbermode (and thus a defaultstring) forNUMERIC/DECIMALcolumn types of all dialects, similarly to theBIGINT'snumberandbigintmodes. This allows to use regular JS numbers if we know the column does not use values with more than ~15 significant digits.I've only added tests for
pgand itspostgres-jsdriver for now. If this PR gains traction and a merge is considered, I will take care of other dialects and drivers tests.