Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state to splash screen (Issue 57) #69

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

jama5262
Copy link
Contributor

What is the Purpose?

Add state to splash screen

What was the approach?

Added get and set functionality to the Preferences interface and add implementation to edit the splash screen state in the PreferencesImpl class

Are there any concerns to addressed further before or after merging this PR?

Also decreased splash screen animation duration by half

Mentions?

@wangerekaharun @michaelbukachi

Issue(s) affected?

#57

Copy link
Contributor

@wangerekaharun wangerekaharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great,

One request however, though this should be on the previous PR, can we have the documentation on how to add functions to the Shared Preference Implementation class in core on ReadME

@wangerekaharun
Copy link
Contributor

@wangerekaharun
Copy link
Contributor

@jama5262 am merging this, you can work on the documentation part and reference it to #4

@wangerekaharun wangerekaharun merged commit 51582fd into droidconKE:develop Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants