Skip to content
This repository has been archived by the owner on Jan 5, 2018. It is now read-only.

Add Media Context and Media Bundle Condition plugins. #79

Open
wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from

Conversation

steveoliver
Copy link

Adds 'media' context and 'media bundle' condition plugins for use with blocks.

@steveoliver
Copy link
Author

While the tests introduced in this PR pass, the build is failing on unrelated Drupal\media_entity\Tests\Views\BulkFormTest.

@Berdir
Copy link
Contributor

Berdir commented Aug 1, 2016

Note: ctools provides generic entity bundle conditions (using derivates). Unfortunately it doesnt provide context yet, but might be worth to consider relying on ctools for that.

Especially because adding your own will result in duplicate conditions for everyone who does have ctools enabled. That's currently already a problem with the node type condition but that's a problem that ctools has to solve.

@steveoliver
Copy link
Author

Thanks @Berdir -- I'll look into ctools. I went this route since it seemed closest to Core.

@sylus
Copy link

sylus commented Sep 21, 2016

Just wanted to say thanks for working on this, was definitely something I needed as well. I gave what was done currently a shot and works great.

@steveoliver
Copy link
Author

You're welcome. Glad you found it useful. Indeed, Ctools provides the condition, but this is still helpful when you want the media context.

@steveoliver
Copy link
Author

Rebased on latest in 8.x-1.x.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants