Autowire Drupal container params and plain values

[claudiu-cristea]

Autowiring works now for services but not for Drupal container parameters or even plain values.

It should be possible to autowire Drupal container params and plain values in his way:

public function __construct(
    #[Autowire(param: 'container.modules')]
    protected array $installedModules,
    #[Autowire(value: 'a plain string')]
    protected string $string,
)
{
    parent:: __construct();
}

[weitzman]

Thanks for the tests

[weitzman]

This file is based on https://github.com/drupal/drupal/blob/11.x/core/lib/Drupal/Core/DependencyInjection/AutowireTrait.php. Looks like this PR wants to expand its duties considerably. I'm not opposed to that, but I fear that this may get tricky to maintain as Symfony evolves.

[weitzman]

I'm hoping that @greg-1-anderson can take a look at changes in this file.

[claudiu-cristea]

Last commit deserves better test coverage

[weitzman]

League container doesn't even support container parameters and string so AutowireTrait how about we cheat and go right to the delegated container for those. If you have a compound container, you can do $container->getContainer() to get the Drupal container, and then ->getParameter() to get the param.

[claudiu-cristea]

I think I have something but no idea how add a new League container service in tests, see AutowireArgumentsTest::testWithDrushContainer()

[weitzman]

Could not instantiate Custom\Library\Drush\Commands\AutowireTestCommands: Cannot autowire service "woot.autowire_test": argument "$argListContainerService" of method "Custom\Library\Drush\Commands\AutowireTestCommands::_construct()", you should configure its value explicitly. [1.06 sec, 8.13 MB]

I am seeing an error when I run drush st -vvv. I'm not sure why this commandfile loaded when I just ddev start, and am not running tests.

[weitzman]

what do we mean "has already been initialized"?

[weitzman]

I dont like commands and AutowireTrait having multiple numbers of params and type hints in create(). How about if we ask commands going forward to always type hint to Psr\Container\ContainerInterface. That receives the compound container. AutowireTrait could pull the drupalContainer out and get container params as needed. We need to declare a service for the drupalContainer in the league container. We already store a reference to the league container inside itself. So this would be a similar service.