Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn about multiple patches #542

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

elliottkember
Copy link

Resolves #541

When using multiple patches, we see errors when multiple patches are applied to the same library. This is because the version numbers are compared without consideration for the suffix.

This PR adds a check to skip the warning. This is useful when using the --error-on-warn flag.

Warning: patch-package detected a patch file version mismatch

  Don't worry! This is probably fine. The patch was still applied
  successfully. Here's the deets:

  Patch file created for

    [email protected]+lowercase

  applied to

    [email protected]

  At path

    node_modules/axios

  This warning is just to give you a heads-up. There is a small chance of
  breakage even though the patch was applied successfully. Make sure the package
  still behaves like you expect (you wrote tests, right?) and then run

    patch-package axios

  to update the version in the patch file name and make this warning go away.


Warning: patch-package detected a patch file version mismatch

  Don't worry! This is probably fine. The patch was still applied
  successfully. Here's the deets:

  Patch file created for

    [email protected]+status-missing

  applied to

    [email protected]

  At path

    node_modules/axios

  This warning is just to give you a heads-up. There is a small chance of
  breakage even though the patch was applied successfully. Make sure the package
  still behaves like you expect (you wrote tests, right?) and then run

    patch-package axios

  to update the version in the patch file name and make this warning go away.

---
patch-package finished with 2 warning(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't warn about mismatched versions when using multiple patches for the same library
1 participant