Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bytewords: remove phf crate in favour of OnceLock #220

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

dspicher
Copy link
Owner

@dspicher dspicher commented Feb 5, 2025

This gets rid of almost two thirds of our dependencies.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 99.80916% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.49%. Comparing base (ed8f722) to head (e4b6ddd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/bytewords.rs 99.80% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   96.50%   97.49%   +0.99%     
==========================================
  Files           5        5              
  Lines        1200     1718     +518     
==========================================
+ Hits         1158     1675     +517     
- Misses         42       43       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This gets rid of almost two thirds of our dependencies.
@dspicher dspicher merged commit 53a48fb into master Feb 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant