Merge pull request #96 from salemove/fix/websocket_onclosing

Fix WebSocket not closed in onClosing
dsrees · Aug 2, 2023 · 1118da2 · 1118da2
2 parents 5248447 + 28f0086
commit 1118da2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/main/kotlin/org/phoenixframework/Transport.kt b/src/main/kotlin/org/phoenixframework/Transport.kt
@@ -155,6 +155,7 @@ class WebSocketTransport(
 
   override fun onClosing(webSocket: WebSocket, code: Int, reason: String) {
     this.readyState = Transport.ReadyState.CLOSING
+    webSocket.close(code, reason)
   }
 
   override fun onMessage(webSocket: WebSocket, text: String) {

diff --git a/src/test/kotlin/org/phoenixframework/WebSocketTransportTest.kt b/src/test/kotlin/org/phoenixframework/WebSocketTransportTest.kt
@@ -136,6 +136,7 @@ class WebSocketTransportTest {
       transport.readyState = Transport.ReadyState.OPEN
 
       transport.onClosing(mockWebSocket, 10, "reason")
+      verify(mockWebSocket).close(10, "reason")
       assertThat(transport.readyState).isEqualTo(Transport.ReadyState.CLOSING)
     }