Fix bug with pre-release parsing #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this extra conditional, a pre-release version of 0 gets parsed as an AlphaNumeric rather than a Numeric. Fixes #73
|
I have tested this patch with @alexcrichton 's test in rust-lang/cargo#2337 (comment) and it seems to have worked. I'm going to merge this and cut a new version with it so that Cargo can pick up the fix, might take a few hours though. |
steveklabnik
added a commit
that referenced
this pull request
Feb 1, 2016
Fix bug with pre-release parsing
|
Thanks @steveklabnik! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this extra conditional, a pre-release version of 0 gets parsed as an
AlphaNumeric rather than a Numeric.
Fixes #73
@wycats do you have any idea why this conditional was included here?