Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve template bootstraper script #106

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

hatamiarash7
Copy link
Contributor

@samansmink
Copy link
Collaborator

Hey @hatamiarash7 thanks for the PR! This looks like a good fix to me.

There's a CI failure though that seems to be related to your PR: it's the workflow that tests the bootstrapping script

@hatamiarash7
Copy link
Contributor Author

@samansmink There was a small issue with replacing multiple words on a line, which has been fixed.

@hatamiarash7
Copy link
Contributor Author

Any update?

@samansmink samansmink merged commit bd7cbc7 into duckdb:main Feb 11, 2025
26 checks passed
@samansmink
Copy link
Collaborator

LGTM, thanks @hatamiarash7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants