Skip to content

Commit

Permalink
Cancelled the burst animation when scrolling.
Browse files Browse the repository at this point in the history
  • Loading branch information
anikiki committed Jan 30, 2025
1 parent e220d48 commit 12efae4
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -955,6 +955,9 @@ class BrowserTabFragment :
if (scrollFraction == 0.0f) {
binding.trackersBlockedSlidingView.gone()
} else {
if (binding.trackersBurstAnimationView.isAnimating) {
binding.trackersBurstAnimationView.cancelAnimation()
}
binding.trackersBlockedSlidingView.show()
}
binding.trackers.text = viewModel.trackersCount()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import android.view.View
import androidx.coordinatorlayout.widget.CoordinatorLayout
import androidx.core.view.ViewCompat
import androidx.lifecycle.MutableLiveData
import com.airbnb.lottie.LottieAnimationView
import com.duckduckgo.app.browser.R
import com.duckduckgo.app.global.model.PrivacyShield
import com.duckduckgo.app.global.model.Site
Expand All @@ -46,9 +47,12 @@ class TrackersBlockedViewSlideBehavior(
private var gravity: Int? = null
private var trackers: DaxTextView? = null
private var website: DaxTextView? = null
private var trackersBurstAnimationView: LottieAnimationView? = null

override fun layoutDependsOn(parent: CoordinatorLayout, child: View, dependency: View): Boolean {
if (dependency.id == R.id.newOmnibarBottom) {
if (dependency.id == R.id.trackersBurstAnimationView) {
trackersBurstAnimationView = dependency as LottieAnimationView
} else if (dependency.id == R.id.newOmnibarBottom) {
if (gravity == null) {
val layoutParams = child.layoutParams as? CoordinatorLayout.LayoutParams
gravity = layoutParams?.gravity
Expand Down Expand Up @@ -80,6 +84,9 @@ class TrackersBlockedViewSlideBehavior(
val site = siteLiveData.value
trackers?.text = site?.trackerCount.toString()
website?.text = site?.url?.extractDomain()
if (trackersBurstAnimationView?.isAnimating == true) {
trackersBurstAnimationView?.cancelAnimation()
}
child.show()
}
super.onNestedPreScroll(coordinatorLayout, child, target, dx, dy, consumed, type)
Expand Down

0 comments on commit 12efae4

Please sign in to comment.