Tried, failed to fix globe icon; mvp for related tests

(cherry picked from commit 51d4367)
duckduckgo · Jan 20, 2025 · 60fa4b0 · 60fa4b0
1 parent 8800de7
commit 60fa4b0
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/app/src/main/java/com/duckduckgo/app/browser/omnibar/OmnibarLayoutViewModel.kt b/app/src/main/java/com/duckduckgo/app/browser/omnibar/OmnibarLayoutViewModel.kt
@@ -304,6 +304,7 @@ class OmnibarLayoutViewModel @Inject constructor(
                         Error -> GLOBE
                         NewTab -> SEARCH
                         SSLWarning -> GLOBE
+                        MaliciousSiteWarning -> GLOBE
                         else -> SEARCH
                     }
                 }

diff --git a/app/src/test/java/com/duckduckgo/app/browser/omnibar/OmnibarLayoutViewModelTest.kt b/app/src/test/java/com/duckduckgo/app/browser/omnibar/OmnibarLayoutViewModelTest.kt
@@ -294,6 +294,17 @@ class OmnibarLayoutViewModelTest {
         }
     }
 
+    @Test
+    fun whenViewModeChangedToMaliciousSiteWarningThenViewStateCorrect() = runTest {
+        testee.onViewModeChanged(ViewMode.MaliciousSiteWarning)
+
+        testee.viewState.test {
+            val viewState = awaitItem()
+            assertTrue(viewState.leadingIconState == LeadingIconState.GLOBE)
+            assertTrue(viewState.scrollingEnabled)
+        }
+    }
+
     @Test
     fun whenViewModeChangedToNewTabThenViewStateCorrect() = runTest {
         testee.onViewModeChanged(ViewMode.NewTab)
@@ -338,6 +349,17 @@ class OmnibarLayoutViewModelTest {
         }
     }
 
+    @Test
+    fun whenViewModeChangedToMaliciousSiteWarningAndFocusThenViewStateCorrect() = runTest {
+        testee.onOmnibarFocusChanged(true, RANDOM_URL)
+        testee.onViewModeChanged(ViewMode.MaliciousSiteWarning)
+
+        testee.viewState.test {
+            val viewState = expectMostRecentItem()
+            assertTrue(viewState.leadingIconState == LeadingIconState.SEARCH)
+        }
+    }
+
     @Test
     fun whenViewModeChangedToNewTabAndFocusThenViewStateCorrect() = runTest {
         testee.onOmnibarFocusChanged(true, RANDOM_URL)

diff --git a/...java/com/duckduckgo/app/browser/webview/RealMaliciousSiteBlockerWebViewIntegrationTest.kt b/...java/com/duckduckgo/app/browser/webview/RealMaliciousSiteBlockerWebViewIntegrationTest.kt
@@ -44,6 +44,7 @@ class RealMaliciousSiteBlockerWebViewIntegrationTest {
         dispatchers = coroutineRule.testDispatcherProvider,
         appCoroutineScope = coroutineRule.testScope,
         isMainProcess = true,
+        exemptedUrlsHolder = ExemptedUrlsHolder(),
     )
 
     @Before