Shrink the FAB on scroll down, extend on up

duckduckgo · Jan 27, 2025 · 79bc6aa · 79bc6aa
1 parent 5c701ea
commit 79bc6aa
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherActivity.kt b/app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherActivity.kt
@@ -47,7 +47,7 @@ import com.duckduckgo.app.pixels.AppPixelName
 import com.duckduckgo.app.settings.SettingsActivity
 import com.duckduckgo.app.settings.db.SettingsDataStore
 import com.duckduckgo.app.statistics.pixels.Pixel
-import com.duckduckgo.app.tabs.TabMultiSelectionFeature
+import com.duckduckgo.app.tabs.TabManagerFeatureFlags
 import com.duckduckgo.app.tabs.model.TabEntity
 import com.duckduckgo.app.tabs.model.TabSwitcherData.LayoutType
 import com.duckduckgo.app.tabs.ui.TabSwitcherViewModel.Command
@@ -122,7 +122,7 @@ class TabSwitcherActivity : DuckDuckGoActivity(), TabSwitcherListener, Coroutine
     lateinit var duckChat: DuckChat
 
     @Inject
-    lateinit var tabMultiSelectionFeature: TabMultiSelectionFeature
+    lateinit var tabManagerFeatureFlags: TabManagerFeatureFlags
 
     private val viewModel: TabSwitcherViewModel by bindViewModel()
 
@@ -160,7 +160,7 @@ class TabSwitcherActivity : DuckDuckGoActivity(), TabSwitcherListener, Coroutine
     }
 
     private fun configureFab() {
-        if (tabMultiSelectionFeature.self().isEnabled()) {
+        if (tabManagerFeatureFlags.multiSelection().isEnabled()) {
             tabsFab.show()
             tabsFab.setOnClickListener {
                 viewModel.onFabClicked()
@@ -207,21 +207,16 @@ class TabSwitcherActivity : DuckDuckGoActivity(), TabSwitcherListener, Coroutine
         tabsRecycler.addItemDecoration(tabItemDecorator)
         tabsRecycler.setHasFixedSize(true)
 
-        if (tabMultiSelectionFeature.self().isEnabled()) {
+        if (tabManagerFeatureFlags.multiSelection().isEnabled()) {
             tabsRecycler.addOnScrollListener(
                 object : RecyclerView.OnScrollListener() {
                     override fun onScrolled(recyclerView: RecyclerView, dx: Int, dy: Int) {
                         super.onScrolled(recyclerView, dx, dy)
-                        if (dy < 0) {
+                        if (dy > 0) {
                             tabsFab.shrink()
-                        }
-                    }
-
-                    override fun onScrollStateChanged(recyclerView: RecyclerView, newState: Int) {
-                        if (newState == RecyclerView.SCROLL_STATE_IDLE) {
+                        } else if (dy < 0) {
                             tabsFab.extend()
                         }
-                        super.onScrollStateChanged(recyclerView, newState)
                     }
                 },
             )