Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AI Chat Entry Point #5415

Merged
merged 16 commits into from
Jan 18, 2025
Merged

Add AI Chat Entry Point #5415

merged 16 commits into from
Jan 18, 2025

Conversation

nshuba
Copy link
Collaborator

@nshuba nshuba commented Dec 19, 2024 •
edited by joshliebe
Loading

Task/Issue URL: https://app.asana.com/0/1202096681738622/1208794467966747/f

Description

Implement AI Chat entry point in browser menu

Steps to test this PR

Basic flow

  • Enable the “newSettings” feature flag and restart the app
  • Enable the “aiChat” feature flag - Duck.ai should now be visible in Settings
  • Browse to any site and click on the browser menu - Duck.ai should be visible after New Tab
  • Click on Duck.ai - AI chat should open (you may need to onboard)
  • Ask the chat for some links and click on one - the dedicate AI chat WebView should close and a new tab should be opened with the link you clicked
  • In any tab, navigate to “duck.ai” and verify that the chat you started above shows up in recent chats
  • Open the Tab Switcher Activity and verify that Duck.ai is available in the browser menu here as well. Verify that clicking on it opens AI chat.

User and config settings

  • Disable “aiChat” feature flag
  • Verify that Duck.ai is no longer visible in regular browsing menu and in Tab Switcher Activity
  • Re-enable “aiChat” feature flag and set the “aiChatURL” setting to something else
  • Verify that clicking the Duck.ai from browser menu now takes you to the new URL
  • Go to Settings -> Duck.ai and disable “Show Duck.ai in Browser Menu"
  • Verify that Duck.ai is no longer visible in regular browsing menu and in Tab Switcher Activity
  • Now disable the “aiChat” feature flag again and then re-enable it
  • Verify that Duck.ai is still not visible in regular browsing menu and in Tab Switcher Activity
  • Re-enable the “Show Duck.ai in Browser Menu” setting
  • Verify that Duck.ai is now again visible in regular browsing menu and in Tab Switcher Activity

UI changes

See screenshots in https://app.asana.com/0/1202096681738622/1208991287872492/f

@nshuba nshuba force-pushed the nastia/feature/ai_chat_entry branch 3 times, most recently from eaca222 to faa5cbc Compare December 21, 2024 17:42
@nshuba nshuba changed the title [WIP] Testing [WIP] Add AI Chat Entry Point Dec 25, 2024
@joshliebe joshliebe self-assigned this Jan 6, 2025
joshliebe
joshliebe reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a first pass and left a bunch of mostly minor comments. Tested it and it's working as expected so far 👏

@nshuba nshuba force-pushed the nastia/feature/ai_chat_entry branch 2 times, most recently from 481f037 to 401c80e Compare January 7, 2025 23:03
@nshuba nshuba changed the title [WIP] Add AI Chat Entry Point Add AI Chat Entry Point Jan 11, 2025
@nshuba nshuba marked this pull request as ready for review January 11, 2025 18:00
@nshuba nshuba force-pushed the nastia/feature/ai_chat_entry branch from 3d73e1d to 91760d3 Compare January 15, 2025 20:21
joshliebe
joshliebe approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but otherwise LGTM! Nicely done 🙂

@nshuba nshuba merged commit b136155 into develop Jan 18, 2025
5 checks passed
@nshuba nshuba deleted the nastia/feature/ai_chat_entry branch January 18, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aitorvs aitorvs aitorvs left review comments

@joshliebe joshliebe joshliebe approved these changes

Assignees

@joshliebe joshliebe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nshuba @joshliebe @aitorvs