Bookmarks: New toolbar for sorting feature flag #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
malmstein
force-pushed
the
feature/david/01-09-bookmarks_new_toolbar_for_sorting_feature_flag
branch
3 times, most recently
from
ba072fe to
f2c4186
Compare
mikescamell
reviewed
Jan 15, 2025
...saved-sites-impl/src/main/java/com/duckduckgo/savedsites/impl/bookmarks/BookmarksActivity.kt
Outdated
Show resolved
Hide resolved
mikescamell
reviewed
Jan 15, 2025
common/common-ui/src/main/java/com/duckduckgo/common/ui/view/PopupMenuItemView.kt
Show resolved
Hide resolved
mikescamell
reviewed
Jan 15, 2025
...saved-sites-impl/src/main/java/com/duckduckgo/savedsites/impl/bookmarks/BookmarksActivity.kt
Outdated
Show resolved
Hide resolved
mikescamell
reviewed
Jan 15, 2025
...saved-sites-impl/src/main/java/com/duckduckgo/savedsites/impl/bookmarks/BookmarksActivity.kt
Outdated
Show resolved
Hide resolved
mikescamell
approved these changes
Jan 15, 2025
malmstein
force-pushed
the
feature/david/01-09-bookmarks_new_toolbar_for_sorting_feature_flag
branch
from
317ffa4 to
f4ab35f
Compare
Task/Issue URL: https://app.asana.com/0/0/1209107275709086/f ### Description This PR adds the name sorting functionality. ### Steps to test this PR Ensure `bookmarksSorting` feature flag is enabled _Switch between manual and name sorting_ - [x] Install the app and add several bookmarks and folders - [x] Open Bookmarks and the overflow menu - [x] Verify Sort Manual is enabled - [x] Move bookmarks around - [x] Change to Sort by Name mode - [x] Verify Bookmarks are sorted by name ascending (bookmarks and folders) - [x] Switch back to Manual mode - [x] Verify bookmarks are shown in the original order - [x] Switch between modes a few times - [x] Verify results are correct _Can’t reorder in Sort by Name mode_ - [x] Assuming a few bookmarks are present - [x] Open bookmarks and select Sort Manual - [x] Try to drag bookmarks and folders - [x] Verify order can be changed - [x] Switch to Sort by Name mode - [x] Try to drag bookmarks and folders - [x] Verify items can’t be moved - [x] Verify that a snackbar appears _Persistance of bookmarks order_ - [x] Assuming a few bookmarks are present - [x] Open bookmarks and select Sort by Name - [x] Close the app and open it again - [x] Verify Sort by Name mode is selected --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1209161541679768
malmstein
deleted the
feature/david/01-09-bookmarks_new_toolbar_for_sorting_feature_flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1174433894299346/1209107275709085/f
Description
This PR adds the new toolbar for the Bookmarks screen under the feature flag
Note that the select sort icon doesn’t react to changes yet
Steps to test this PR
Toolbar functionality
UI changes