Update Settings: Update feature flag #5480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need this to be able to do the rollout, it cannot be done at top level the top level feature name is now "settingsScreen" I will rename NewSettingsFeature to SettingsScreenFeature next
mikescamell
force-pushed
the
feature/mike/update-settings/convert-to-remote-feature-toggle
branch
from
935b191 to
e246e53
Compare
malmstein
approved these changes
Jan 17, 2025
mikescamell
deleted the
feature/mike/update-settings/convert-to-remote-feature-toggle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1209171570131451/f
Description
Updates the feature toggle to
settingsPageand add two new sub-flags for controlling the rollout:newSettingsPagefor showing the screen and all changes except the privacy pro sectionnewPrivacyProSectionfor showing/hiding the new privacy pro section itemsSteps to test this PR
New Settings
newSettingsPagein the Feature Flag InventoryNew Privacy Pro Section
newPrivacyProSectionin the Feature Flag InventoryNew Privacy Pro Section and legacy settings
newSettingsPagein the Feature Flag InventoryUI changes
N/A