Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional "default browser" prompts: control #5486

Open
wants to merge 1 commit into
base: feature/lukasz-p/default-browser-prompts-variant-2
Choose a base branch
from
+10 −0
Open

Additional "default browser" prompts: control #5486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...duckduckgo/app/browser/defaultbrowsing/prompts/DefaultBrowserPromptsExperimentVariants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,15 @@ interface DefaultBrowserPromptsExperimentStageEvaluator {
val targetCohort: AdditionalPromptsCohortName
suspend fun evaluate(newStage: ExperimentStage): DefaultBrowserPromptsExperimentStageAction

@ContributesMultibinding(scope = AppScope::class)
class Control @Inject constructor() : DefaultBrowserPromptsExperimentStageEvaluator {

override val targetCohort = AdditionalPromptsCohortName.CONTROL

override suspend fun evaluate(newStage: ExperimentStage): DefaultBrowserPromptsExperimentStageAction =
DefaultBrowserPromptsExperimentStageAction.disableAll
}

@ContributesMultibinding(scope = AppScope::class)
class Variant2 @Inject constructor() : DefaultBrowserPromptsExperimentStageEvaluator {

Expand Down
1 change: 1 addition & 0 deletions ...com/duckduckgo/app/browser/defaultbrowsing/prompts/DefaultBrowserPromptsFeatureToggles.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ interface DefaultBrowserPromptsFeatureToggles {
fun additionalPrompts(): Toggle

enum class AdditionalPromptsCohortName(override val cohortName: String) : CohortName {
CONTROL("control"),
VARIANT_2("variant_2"),
}
}
Loading