Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the PS review script #5493

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

aitorvs
Copy link
Collaborator

@aitorvs aitorvs commented Jan 18, 2025

Task/Issue URL: https://app.asana.com/0/1198194956794324/1209186880742773/f

Description

Improvements to the PS review analysis automation

  • print information for all star revies, not only anomalies
  • reviews are not shown if z-score is negative
  • added z-score information
  • added info table to know how to interpret data
  • added visuals to spot anomalies
  • generate the report later in the day so that it includes more reviews

Steps to test this PR

Run workflow for this branch and verify the task is created properly. If the task was already created it'll need to be closed, else creation will be skipped.

Copy link
Collaborator Author

aitorvs commented Jan 18, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@aitorvs aitorvs force-pushed the feature/aitor/ps-analysis branch 7 times, most recently from 0880842 to c5a34e1 Compare January 22, 2025 17:44
@aitorvs aitorvs marked this pull request as ready for review January 22, 2025 17:45
Copy link
Contributor

@karlenDimla karlenDimla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just see what gets generated when it runs later at 2pm

@aitorvs aitorvs force-pushed the feature/aitor/ps-analysis branch from c5a34e1 to b39bd47 Compare January 24, 2025 12:25
@aitorvs aitorvs merged commit 05e41b3 into develop Jan 24, 2025
6 checks passed
@aitorvs aitorvs deleted the feature/aitor/ps-analysis branch January 24, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants