Ensure custom views cancel coroutine scopes in onDetachedFromWindow #5551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
anikiki
force-pushed
the
fix/aitor/cancel-scope-in-onDetachedFromWindow
branch
from
6da7214 to
e667ac5
Compare
…nly when it is visible.
…update only when it is visible." This reverts commit e667ac5.
anikiki
force-pushed
the
fix/aitor/cancel-scope-in-onDetachedFromWindow
branch
from
e667ac5 to
d915f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1198194956794324/1209242164061666/f
Description
Ensure all custom views cancel coroutineScope
Steps to test this PR
Smoke tests features that related to the custom view changes