Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Feature Flag for Autofill Service #5567

Conversation

cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Jan 31, 2025

Task/Issue URL: https://app.asana.com/0/1149059203486286/1209289199349624/f

Description

Adds FFs around Autofill Service. See task for details.

Steps to test this PR

  • checkout the branch
  • go to AutofillServiceFeature, and remove all InternalAlwaysEnabled (otherwise is not possible to test)

Feature 1

  • install the app
  • Go to autofill system settings, ensure DuckDuckGo is not listed there
  • open the app, go to feature flags internal setting, enable Autofill Service
  • restart the app
  • Go to autofill system settings, ensure DuckDuckGo is listed there
  • Selected DDG

Feature 2

  • Perform one test from https://app.asana.com/0/1149059203486286/1209279712661812/f on a native app
  • It should not suggest you anything
  • open the app, go to feature flags internal setting, enable canUpdateAppToDomainDataset and canMapAppToDomain
  • restart the app
  • Repeat the test from step 1
  • Now you should see some suggestions (since we have enabled mapping between apps and domains)

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@cmonfortep
Copy link
Contributor Author

cmonfortep commented Jan 31, 2025

@cmonfortep cmonfortep requested a review from CDRussell January 31, 2025 10:46
@cmonfortep cmonfortep force-pushed the feature/cristian/autofill/ff_autofill_service branch 2 times, most recently from 1552747 to a5e0e7e Compare January 31, 2025 14:21
@cmonfortep cmonfortep force-pushed the feature/karl/autofill/mapping branch from 5d63aa5 to 810b9c2 Compare February 4, 2025 13:52
@cmonfortep cmonfortep force-pushed the feature/cristian/autofill/ff_autofill_service branch from a5e0e7e to dec51cb Compare February 4, 2025 13:53
@cmonfortep cmonfortep force-pushed the feature/karl/autofill/mapping branch from 810b9c2 to 3844218 Compare February 5, 2025 14:08
@cmonfortep cmonfortep force-pushed the feature/cristian/autofill/ff_autofill_service branch from dec51cb to fa38cab Compare February 5, 2025 14:08
@cmonfortep cmonfortep force-pushed the feature/karl/autofill/mapping branch from 3844218 to bbc04a7 Compare February 5, 2025 14:15
@cmonfortep cmonfortep force-pushed the feature/cristian/autofill/ff_autofill_service branch from fa38cab to 881043c Compare February 5, 2025 14:15
@cmonfortep cmonfortep merged commit 6fc9381 into feature/karl/autofill/mapping Feb 5, 2025
4 of 5 checks passed
@cmonfortep cmonfortep deleted the feature/cristian/autofill/ff_autofill_service branch February 5, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants