Add rule for Shopify Customer Privacy CMP #616
Conversation
tests/shopify.spec.ts
Outdated
| 'https://store.leviton.com/collections/smart-load-center', | ||
| 'https://snaprevise.co.uk/', | ||
| 'https://hannun.com/', |
There was a problem hiding this comment.
The tests seem to fail, not sure what it is... npm run test -- --grep shopify
There was a problem hiding this comment.
Oops, I assumed that these tests were ran on GitHub Actions and so saw the ✅ in the PR and thought nothing further.
The first two failures were due to EVAL_SHOPIFY_TEST. It doesn’t seem like window.Shopify works in Playwright. I switched to evaluating based on document.cookie which is the approach we take for other rules.
The test for https://hannun.com/ I couldn’t get to work no matter what I tried. For some reason autoconsentSendMessage never fires on that page in Playwright. The cookie popup is handled successfully when I test in the browser. I spent an hour debugging but, having gotten nowhere, gave up, and replaced it with the next highest ranked site from PublicWWW.
There was a problem hiding this comment.
Thanks @noisysocks! Yeah, these tests are flaky due to sites changing, so we don't run them in CI. We may rely on coverage data for these tests, but it's out of scope.
https://app.asana.com/0/1209121419454298/1208980207307210/f