-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Malicious Site Protection - Disabled state in case there are issues during rollout #2745
base: main
Are you sure you want to change the base?
Conversation
Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana). |
Generated file outputs:Time updated: Wed, 12 Feb 2025 09:54:16 GMT legacytrackers-unprotected-temporary.txt (13 more)
v3/ios-config.json--- v3/ios-config.json
+++ v3/ios-config.json
@@ -6526,18 +6526,18 @@
},
"exceptions": []
},
"maliciousSiteProtection": {
- "state": "internal",
+ "state": "disabled",
"exceptions": [
{
"domain": "broken.third-party.site",
"reason": "A test page that helps us verify if exceptions work correctly."
}
],
"features": {
"onByDefault": {
- "state": "internal"
+ "state": "disabled"
}
},
"settings": {
"hashPrefixUpdateFrequency": 20,
latestv4/android-config.json (12 more)
v4/ios-config.json--- v4/ios-config.json
+++ v4/ios-config.json
@@ -6030,17 +6030,17 @@
},
"exceptions": []
},
"maliciousSiteProtection": {
- "state": "internal",
+ "state": "disabled",
"exceptions": [
{
"domain": "broken.third-party.site"
}
],
"features": {
"onByDefault": {
- "state": "internal"
+ "state": "disabled"
}
},
"settings": {
"hashPrefixUpdateFrequency": 20,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approved, in case it's needed.
Asana Task/Github Issue: https://app.asana.com/0/1206329551987282/1209385826333906
Description
This PR disables the Malicious Site Protection feature to allow for a quick response in case there are issues during the rollout phases. This change should not be merged. It is intended solely to be released if problems arise during the rollout process.
Feature change process:
Additional info:
Site breakage mitigation process:
Brief explanation
Reported URL:
Problems experienced:
Platforms affected:
Tracker(s) being unblocked:
Feature being disabled:
I have referenced the URL of this PR as the "reason" value for the exception (where applicable).
This change is a speculative mitigation to fix reported breakage.
Reference