Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import package.json to work with bundlers #521

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

claytondus
Copy link

In this PR:

  • Bug fix (non-breaking change which fixes an issue)
    Imports package.json in the get-status handler so that the package can be bundled (as with deployment to AWS Lambda).

Issues reference:

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you lint your code with pnpm lint locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran build with pnpm build of your changes locally?
  • Have you successfully ran tests with pnpm test of your changes locally?
  • Have you commit using Conventional Commits?

@fox1t
Copy link
Contributor

fox1t commented Feb 11, 2025

Hey, thanks for the PR!
I do not like adding package.json to the bundle since it is not a source file and is not "watched" by the tsconfig. In fact, your PR changes the build folder structure and breaks in docker (we can adjust the docker file to fix it, though).
What about entirely dropping the version from that import? Do we care? It seems like a non-feature that we can get rid of.

@lucalas and @matteovivona, what do you think?

@matteovivona
Copy link
Contributor

Maybe we can do something like this #524
the version on status page was useful for understanding the actual server version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants